From 33666b448f15687ceaf61eac405d945391fe7066 Mon Sep 17 00:00:00 2001 From: Harry van Haaren Date: Wed, 11 Mar 2020 14:39:27 +0000 Subject: [PATCH] service: fix crash on exit This commit releases all service cores from their role, returning them to ROLE_RTE on rte_service_finalize(). This fixes an issue relating to the service cores causing a race-condition on rte_eal_cleanup(), where the service core could still be executing while the main thread has already free-d the service memory, leading to a segfault. Fixes: da23f0aa87d8 ("service: fix memory leak with new function") Cc: stable@dpdk.org Reported-by: David Marchand Reported-by: Aaron Conole Signed-off-by: David Marchand Signed-off-by: Harry van Haaren Acked-by: Aaron Conole --- lib/librte_eal/common/rte_service.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/librte_eal/common/rte_service.c b/lib/librte_eal/common/rte_service.c index 7e537b8cd2..b0b78baabd 100644 --- a/lib/librte_eal/common/rte_service.c +++ b/lib/librte_eal/common/rte_service.c @@ -122,6 +122,9 @@ rte_service_finalize(void) if (!rte_service_library_initialized) return; + rte_service_lcore_reset_all(); + rte_eal_mp_wait_lcore(); + rte_free(rte_services); rte_free(lcore_states); -- 2.20.1