From 3419c9a7e532832182c4ac40c888658ab6f0ae4b Mon Sep 17 00:00:00 2001 From: Ivan Malov Date: Mon, 25 Oct 2021 14:04:10 +0300 Subject: [PATCH] net/sfc: rename ethdev m-port retrieval helper The function in question has an unfortunate name that reads like finding a SW switch port entry. In fact just one of the two m-ports is retrieved from that entry. Signed-off-by: Ivan Malov Reviewed-by: Andrew Rybchenko --- drivers/net/sfc/sfc_mae.c | 10 +++++----- drivers/net/sfc/sfc_switch.c | 6 +++--- drivers/net/sfc/sfc_switch.h | 6 +++--- 3 files changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/net/sfc/sfc_mae.c b/drivers/net/sfc/sfc_mae.c index 455744c570..84b13925ff 100644 --- a/drivers/net/sfc/sfc_mae.c +++ b/drivers/net/sfc/sfc_mae.c @@ -1276,8 +1276,8 @@ sfc_mae_rule_parse_item_port_id(const struct rte_flow_item *item, "The port ID is too large"); } - rc = sfc_mae_switch_port_by_ethdev(ctx_mae->sa->mae.switch_domain_id, - spec->id, &mport_sel); + rc = sfc_mae_switch_get_ethdev_mport(ctx_mae->sa->mae.switch_domain_id, + spec->id, &mport_sel); if (rc != 0) { return rte_flow_error_set(error, rc, RTE_FLOW_ERROR_TYPE_ITEM, item, @@ -1335,7 +1335,7 @@ sfc_mae_rule_parse_item_port_representor(const struct rte_flow_item *item, if (spec == NULL) return 0; - rc = sfc_mae_switch_port_by_ethdev( + rc = sfc_mae_switch_get_ethdev_mport( ctx_mae->sa->mae.switch_domain_id, spec->port_id, &mport_sel); if (rc != 0) { @@ -3406,8 +3406,8 @@ sfc_mae_rule_parse_action_port_id(struct sfc_adapter *sa, port_id = (conf->original != 0) ? sas->port_id : conf->id; - rc = sfc_mae_switch_port_by_ethdev(mae->switch_domain_id, - port_id, &mport); + rc = sfc_mae_switch_get_ethdev_mport(mae->switch_domain_id, + port_id, &mport); if (rc != 0) { sfc_err(sa, "failed to find MAE switch port SW entry for RTE ethdev port %u: %s", port_id, strerror(rc)); diff --git a/drivers/net/sfc/sfc_switch.c b/drivers/net/sfc/sfc_switch.c index 265a17f4c4..3f7518fa30 100644 --- a/drivers/net/sfc/sfc_switch.c +++ b/drivers/net/sfc/sfc_switch.c @@ -537,9 +537,9 @@ sfc_mae_find_switch_port_by_ethdev(uint16_t switch_domain_id, } int -sfc_mae_switch_port_by_ethdev(uint16_t switch_domain_id, - uint16_t ethdev_port_id, - efx_mport_sel_t *mport_sel) +sfc_mae_switch_get_ethdev_mport(uint16_t switch_domain_id, + uint16_t ethdev_port_id, + efx_mport_sel_t *mport_sel) { struct sfc_mae_switch_port *port; int rc; diff --git a/drivers/net/sfc/sfc_switch.h b/drivers/net/sfc/sfc_switch.h index 7917141038..a5a0fb4fc5 100644 --- a/drivers/net/sfc/sfc_switch.h +++ b/drivers/net/sfc/sfc_switch.h @@ -102,9 +102,9 @@ int sfc_mae_assign_switch_port(uint16_t switch_domain_id, int sfc_mae_clear_switch_port(uint16_t switch_domain_id, uint16_t switch_port_id); -int sfc_mae_switch_port_by_ethdev(uint16_t switch_domain_id, - uint16_t ethdev_port_id, - efx_mport_sel_t *mport_sel); +int sfc_mae_switch_get_ethdev_mport(uint16_t switch_domain_id, + uint16_t ethdev_port_id, + efx_mport_sel_t *mport_sel); int sfc_mae_switch_port_id_by_entity(uint16_t switch_domain_id, const efx_mport_sel_t *entity_mportp, -- 2.39.5