From 355a3c96235d6e24b03207ea141ddd5cacda36f1 Mon Sep 17 00:00:00 2001 From: Thierry Herbelot Date: Mon, 24 May 2021 11:01:44 +0200 Subject: [PATCH] app/testpmd: move conntrack update after null check Use out only after it was checked not to be null. Fixes: 4d07cbefe3ba0 ("app/testpmd: add commands for conntrack") Cc: stable@dpdk.org Signed-off-by: Thierry Herbelot Reviewed-by: Bing Zhao Acked-by: Aman Deep Singh --- app/test-pmd/cmdline_flow.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c index 1c587bb7b8..7645b3cc90 100644 --- a/app/test-pmd/cmdline_flow.c +++ b/app/test-pmd/cmdline_flow.c @@ -6631,10 +6631,10 @@ parse_vc_action_conntrack_update(struct context *ctx, const struct token *token, /* Token name must match. */ if (parse_default(ctx, token, str, len, NULL, 0) < 0) return -1; - ct_modify = (struct rte_flow_modify_conntrack *)out->args.vc.data; /* Nothing else to do if there is no buffer. */ if (!out) return len; + ct_modify = (struct rte_flow_modify_conntrack *)out->args.vc.data; if (ctx->curr == ACTION_CONNTRACK_UPDATE_DIR) { ct_modify->new_ct.is_original_dir = conntrack_context.is_original_dir; -- 2.20.1