From 35c2968b23d35c057214ce29a9b11a08752c1810 Mon Sep 17 00:00:00 2001 From: Qiming Yang Date: Mon, 15 Jul 2019 10:23:56 +0800 Subject: [PATCH] net/ice: fix flow validation ice_flow_valid_attr will return zero on success and a negative value on error. Current return value check logic is opposite of the expected behavior. This patch fixes this issue. Fixes: d76116a4678f ("net/ice: add generic flow API") Cc: stable@dpdk.org Signed-off-by: Qiming Yang Acked-by: Beilei Xing --- drivers/net/ice/ice_generic_flow.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ice/ice_generic_flow.c b/drivers/net/ice/ice_generic_flow.c index d5ff278c40..e6a2c4b163 100644 --- a/drivers/net/ice/ice_generic_flow.c +++ b/drivers/net/ice/ice_generic_flow.c @@ -549,7 +549,7 @@ static int ice_flow_valid_action(struct rte_eth_dev *dev, rte_flow_error_set(error, EINVAL, RTE_FLOW_ERROR_TYPE_ACTION, actions, "Invalid queue ID for" - " ethertype_filter."); + " switch filter."); return -rte_errno; } break; @@ -596,7 +596,7 @@ ice_flow_validate(struct rte_eth_dev *dev, } ret = ice_flow_valid_attr(attr, error); - if (!ret) + if (ret) return ret; inset = ice_flow_valid_pattern(pattern, error); -- 2.20.1