From 36d79278384d4faeb019720a9b043bab0ce7ccb0 Mon Sep 17 00:00:00 2001 From: Andrew Rybchenko Date: Tue, 13 Oct 2020 14:45:22 +0100 Subject: [PATCH] common/sfc_efx/base: fix PHY config failure on Riverhead Riverhead does not support LED control yet. It is perfectly fine to ignore LED set failure because of no support if configured LED mode is the default. Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/common/sfc_efx/base/ef10_phy.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/common/sfc_efx/base/ef10_phy.c b/drivers/common/sfc_efx/base/ef10_phy.c index 3d07c254bf..74a18841d9 100644 --- a/drivers/common/sfc_efx/base/ef10_phy.c +++ b/drivers/common/sfc_efx/base/ef10_phy.c @@ -530,8 +530,16 @@ ef10_phy_reconfigure( #endif rc = efx_mcdi_phy_set_led(enp, phy_led_mode); - if (rc != 0) + if (rc != 0) { + /* + * If LED control is not supported by firmware, we can + * silently ignore default mode set failure + * (see FWRIVERHD-198). + */ + if (rc == EOPNOTSUPP && phy_led_mode == EFX_PHY_LED_DEFAULT) + goto out; goto fail3; + } out: return (0); -- 2.20.1