From 3c581421d0bf78c9073cc9b97179d395bb085838 Mon Sep 17 00:00:00 2001 From: Emmanuel Roullit Date: Tue, 24 Jan 2017 21:48:58 +0100 Subject: [PATCH] net/cxgbe: remove unused variables Found with clang static analysis: drivers/net/cxgbe/sge.c:900:3: warning: Value stored to 'in_use' is never read in_use += q->size; ^ ~~~~~~~ Removing "in_use" variable makes "hw_cidx" variable unused, which is removed too. Fixes: 4a01078b4fd1 ("cxgbe: add Tx support") Cc: stable@dpdk.org Signed-off-by: Emmanuel Roullit Acked-by: Rahul Lakkireddy --- drivers/net/cxgbe/sge.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/net/cxgbe/sge.c b/drivers/net/cxgbe/sge.c index fc03a0c260..37b6090409 100644 --- a/drivers/net/cxgbe/sge.c +++ b/drivers/net/cxgbe/sge.c @@ -890,15 +890,11 @@ static inline int should_tx_packet_coalesce(struct sge_eth_txq *txq, struct sge_txq *q = &txq->q; unsigned int flits, ndesc; unsigned char type = 0; - int credits, hw_cidx = ntohs(q->stat->cidx); - int in_use = q->pidx - hw_cidx + flits_to_desc(q->coalesce.flits); + int credits; /* use coal WR type 1 when no frags are present */ type = (mbuf->nb_segs == 1) ? 1 : 0; - if (in_use < 0) - in_use += q->size; - if (unlikely(type != q->coalesce.type && q->coalesce.idx)) ship_tx_pkt_coalesce_wr(adap, txq); -- 2.20.1