From 3edc242d459b57aed3c63311f17a9138bec4b4cb Mon Sep 17 00:00:00 2001 From: Jasvinder Singh Date: Fri, 20 Jul 2018 12:05:36 +0100 Subject: [PATCH] net/softnic: fix memory illegal access after free While deleting the elements from the linked list, TAILQ_FOREACH causes read from the freed pointer. Fixes the issue by using TAILQ_FOREACH_SAFE instead. Coverity issue: 302867 Fixes: bef50bcb1c47 ("net/softnic: implement start and stop") Signed-off-by: Jasvinder Singh Acked-by: Cristian Dumitrescu --- drivers/net/softnic/rte_eth_softnic_swq.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/softnic/rte_eth_softnic_swq.c b/drivers/net/softnic/rte_eth_softnic_swq.c index 1944fbbfd6..2083d0a976 100644 --- a/drivers/net/softnic/rte_eth_softnic_swq.c +++ b/drivers/net/softnic/rte_eth_softnic_swq.c @@ -6,6 +6,7 @@ #include #include +#include #include "rte_eth_softnic_internals.h" @@ -36,9 +37,9 @@ softnic_swq_free(struct pmd_internals *p) void softnic_softnic_swq_free_keep_rxq_txq(struct pmd_internals *p) { - struct softnic_swq *swq; + struct softnic_swq *swq, *tswq; - TAILQ_FOREACH(swq, &p->swq_list, node) { + TAILQ_FOREACH_SAFE(swq, &p->swq_list, node, tswq) { if ((strncmp(swq->name, "RXQ", strlen("RXQ")) == 0) || (strncmp(swq->name, "TXQ", strlen("TXQ")) == 0)) continue; -- 2.20.1