From 3f326c460ff09146917d6a060cf5715a1b8b6446 Mon Sep 17 00:00:00 2001 From: John Daley Date: Mon, 14 Feb 2022 12:46:10 -0800 Subject: [PATCH] net/enic: fix dereference before null check This patch fixes an issue found by coverity. It checks for a possible null value of "error" before dereferencing it. CID: 375064: Dereference after null check Either the check against null is unnecessary, or there may be a null pointer dereference. Coverity issue: 375064 Fixes: ee806eea59fe ("net/enic: support GENEVE flow item") Signed-off-by: John Daley Reviewed-by: Hyong Youb Kim --- drivers/net/enic/enic_fm_flow.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/enic/enic_fm_flow.c b/drivers/net/enic/enic_fm_flow.c index f0bda19a70..c87d3af847 100644 --- a/drivers/net/enic/enic_fm_flow.c +++ b/drivers/net/enic/enic_fm_flow.c @@ -1204,7 +1204,7 @@ enic_fm_copy_entry(struct enic_flowman *fm, ret = item_info->copy_item(&args); if (ret) { /* If copy_item set the error, return that */ - if (error->type != RTE_FLOW_ERROR_TYPE_NONE) + if (error && error->type != RTE_FLOW_ERROR_TYPE_NONE) return ret; goto item_not_supported; } -- 2.39.5