From 3fe2e5fec82becd43b06fafbb5e7e48326f52468 Mon Sep 17 00:00:00 2001 From: Tetsuya Mukawa Date: Thu, 16 Jun 2016 11:33:09 +0900 Subject: [PATCH] eal: fix argument parsing check This patch fixes wrong error checking of rte_eal_parse_devargs_str(). Currently, a return value of strdup() is wrongly checked. Fixes: 0fe11ec592b2 ("eal: add vdev init and uninit") Signed-off-by: Tetsuya Mukawa Acked-by: David Marchand --- lib/librte_eal/common/eal_common_devargs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_eal/common/eal_common_devargs.c b/lib/librte_eal/common/eal_common_devargs.c index 2bfe54a194..e403717be7 100644 --- a/lib/librte_eal/common/eal_common_devargs.c +++ b/lib/librte_eal/common/eal_common_devargs.c @@ -58,7 +58,7 @@ rte_eal_parse_devargs_str(const char *devargs_str, return -1; *drvname = strdup(devargs_str); - if (drvname == NULL) + if (*drvname == NULL) return -1; /* set the first ',' to '\0' to split name and arguments */ -- 2.20.1