From 422515b9aab0f1161631276d682303356e243c07 Mon Sep 17 00:00:00 2001 From: Adrien Mazarguil Date: Wed, 13 Jun 2018 18:27:43 +0200 Subject: [PATCH] app/testpmd: fix crash when attaching a device Below commit checks global device information to determine if a port uses the softnic driver once initialized. Problem is that this information is not available at this point when a port is initialized interactively through a "port attach XXX" command, crashing testpmd. This patch systematically initializes global device information to address this issue. Fixes: 5b590fbe09b6 ("app/testpmd: add traffic management forwarding mode") Cc: stable@dpdk.org Signed-off-by: Adrien Mazarguil Acked-by: Bernard Iremonger --- app/test-pmd/testpmd.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index 35cf266741..24c1998445 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -2355,16 +2355,15 @@ init_port_config(void) { portid_t pid; struct rte_port *port; - struct rte_eth_dev_info dev_info; RTE_ETH_FOREACH_DEV(pid) { port = &ports[pid]; port->dev_conf.fdir_conf = fdir_conf; + rte_eth_dev_info_get(pid, &port->dev_info); if (nb_rxq > 1) { - rte_eth_dev_info_get(pid, &dev_info); port->dev_conf.rx_adv_conf.rss_conf.rss_key = NULL; port->dev_conf.rx_adv_conf.rss_conf.rss_hf = - rss_hf & dev_info.flow_type_rss_offloads; + rss_hf & port->dev_info.flow_type_rss_offloads; } else { port->dev_conf.rx_adv_conf.rss_conf.rss_key = NULL; port->dev_conf.rx_adv_conf.rss_conf.rss_hf = 0; -- 2.20.1