From 4268cf49e8be2ebcddcb37ffa19a1d7198105540 Mon Sep 17 00:00:00 2001 From: Anatoly Burakov Date: Fri, 27 Jul 2018 09:24:35 +0100 Subject: [PATCH] eal/bsd: silence unsupported interrupts error Currently, nic_uio driver does not support interrupts, so any attempts to install an interrupt handler will fail with a not supported error, which will cause an error message that is confusing to the user. Silence this error by moving it to debug log level, and reword the message to avoid containing the word "Error", to avoid triggering DTS test failures [1]. [1] https://git.dpdk.org/tools/dts/tree/tests/TestSuite_scatter.py?#n110 Fixes: 23150bd8d8a8 ("eal/bsd: add interrupt thread") Signed-off-by: Anatoly Burakov --- lib/librte_eal/bsdapp/eal/eal_interrupts.c | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/lib/librte_eal/bsdapp/eal/eal_interrupts.c b/lib/librte_eal/bsdapp/eal/eal_interrupts.c index 29356f320f..2feee2d528 100644 --- a/lib/librte_eal/bsdapp/eal/eal_interrupts.c +++ b/lib/librte_eal/bsdapp/eal/eal_interrupts.c @@ -156,8 +156,18 @@ rte_intr_callback_register(const struct rte_intr_handle *intr_handle, * add the intr file descriptor into wait list. */ if (kevent(kq, &ke, 1, NULL, 0, NULL) < 0) { - RTE_LOG(ERR, EAL, "Error adding fd %d kevent, %s\n", - src->intr_handle.fd, strerror(errno)); + /* currently, nic_uio does not support interrupts, so + * this error will always be triggered and output to the + * user. so, don't output it unless debug log level set. + */ + if (errno == ENODEV) + RTE_LOG(DEBUG, EAL, "Interrupt handle %d not supported\n", + src->intr_handle.fd); + else + RTE_LOG(ERR, EAL, "Error adding fd %d " + "kevent, %s\n", + src->intr_handle.fd, + strerror(errno)); ret = -errno; goto fail; } -- 2.20.1