From 4582f79c7bd06ff99c0b82b6995c37edda156fea Mon Sep 17 00:00:00 2001 From: Pablo de Lara Date: Thu, 20 Jan 2022 17:04:55 +0000 Subject: [PATCH] crypto/ipsec_mb: fix buffer overrun Memory for ZUC cipher/auth key in session had to be expanded to 32 bytes, instead of 16 bytes, when adding ZUC-256 support. However, impact is low as this memory is part of a union with bigger size than 32 bytes. Coverity issue: 374374 Coverity issue: 374379 Fixes: 8c835018de84 ("crypto/ipsec_mb: support ZUC-256 for aesni_mb") Cc: stable@dpdk.org Signed-off-by: Pablo de Lara Acked-by: Ciara Power --- drivers/crypto/ipsec_mb/pmd_aesni_mb_priv.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/ipsec_mb/pmd_aesni_mb_priv.h b/drivers/crypto/ipsec_mb/pmd_aesni_mb_priv.h index d37cc787a0..d177961ea5 100644 --- a/drivers/crypto/ipsec_mb/pmd_aesni_mb_priv.h +++ b/drivers/crypto/ipsec_mb/pmd_aesni_mb_priv.h @@ -848,7 +848,7 @@ struct aesni_mb_session { struct gcm_key_data gcm_key; /* *< Expanded GCM key */ - uint8_t zuc_cipher_key[16]; + uint8_t zuc_cipher_key[32]; /* *< ZUC cipher key */ snow3g_key_schedule_t pKeySched_snow3g_cipher; /* *< SNOW3G scheduled cipher key */ @@ -893,7 +893,7 @@ struct aesni_mb_session { /* *< k3. */ } cmac; /* *< Expanded XCBC authentication keys */ - uint8_t zuc_auth_key[16]; + uint8_t zuc_auth_key[32]; /* *< ZUC authentication key */ snow3g_key_schedule_t pKeySched_snow3g_auth; /* *< SNOW3G scheduled authentication key */ -- 2.39.5