From 45db8927a832fc3ad717b81387ac765f22d43996 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Beno=C3=AEt=20Canet?= Date: Fri, 27 Feb 2015 11:22:45 +0100 Subject: [PATCH] vhost: add hint on how to add or remove device to a data core MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Let's make sure people will not forget to set and unset VIRTIO_DEV_RUNNING. Signed-off-by: Benoît Canet Acked-by: Huawei Xie --- doc/guides/prog_guide/vhost_lib.rst | 3 ++- lib/librte_vhost/rte_virtio_net.h | 4 ++++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/doc/guides/prog_guide/vhost_lib.rst b/doc/guides/prog_guide/vhost_lib.rst index 0b6eda7836..ba6065da0c 100644 --- a/doc/guides/prog_guide/vhost_lib.rst +++ b/doc/guides/prog_guide/vhost_lib.rst @@ -58,7 +58,8 @@ Vhost API Overview register two callbacks, new_destory and destroy_device. When virtio device is activated or deactivated by guest virtual machine, the callback will be called, then vSwitch could put the device onto data - core or remove the device from data core. + core or remove the device from data core by setting or unsetting + VIRTIO_DEV_RUNNING on the device flags. * Read/write packets from/to guest virtual machine diff --git a/lib/librte_vhost/rte_virtio_net.h b/lib/librte_vhost/rte_virtio_net.h index 2fc1c448f2..b79bd0b76b 100644 --- a/lib/librte_vhost/rte_virtio_net.h +++ b/lib/librte_vhost/rte_virtio_net.h @@ -130,6 +130,10 @@ struct virtio_memory { /** * Device operations to add/remove device. + * + * Make sure to set VIRTIO_DEV_RUNNING to the device flags in new_device and + * remove it in destroy_device. + * */ struct virtio_net_device_ops { int (*new_device)(struct virtio_net *); /**< Add device. */ -- 2.20.1