From 4a28e831c97cd02e1646337ea6391288f7e8db05 Mon Sep 17 00:00:00 2001 From: Michael Baum Date: Tue, 21 Jul 2020 12:01:09 +0000 Subject: [PATCH] net/mlx4: optimize stack memory size in probe The mlx4_pci_probe function sets a pointer to the mlx4_priv structure, and during that function fills its fields one by one with relevant values. It wants to put a value in the intr_handle field that has all its fields zero except 2. To do so, it initializes a local struct rte_intr_handle type variable and updates it only 2 fields and assigns it into the appropriate field. However, it initializes a very large structure on the stack while not at all certain that this place exists and in any case it is very wasteful. Reset all fields directly to the pointer by memset, then format the 2 fields to the relevant values. Fixes: 63c2f23c852a ("net/mlx4: use a single interrupt handle") Cc: stable@dpdk.org Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/net/mlx4/mlx4.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/net/mlx4/mlx4.c b/drivers/net/mlx4/mlx4.c index e619a749d9..71061a720f 100644 --- a/drivers/net/mlx4/mlx4.c +++ b/drivers/net/mlx4/mlx4.c @@ -1029,10 +1029,9 @@ mlx4_pci_probe(struct rte_pci_driver *pci_drv, struct rte_pci_device *pci_dev) eth_dev->device = &pci_dev->device; rte_eth_copy_pci_info(eth_dev, pci_dev); /* Initialize local interrupt handle for current port. */ - priv->intr_handle = (struct rte_intr_handle){ - .fd = -1, - .type = RTE_INTR_HANDLE_EXT, - }; + memset(&priv->intr_handle, 0, sizeof(struct rte_intr_handle)); + priv->intr_handle.fd = -1; + priv->intr_handle.type = RTE_INTR_HANDLE_EXT; /* * Override ethdev interrupt handle pointer with private * handle instead of that of the parent PCI device used by -- 2.20.1