From 4e0955bddb0880949fb12de3a1a8f07eb9ace832 Mon Sep 17 00:00:00 2001 From: Fiona Trahe Date: Thu, 25 Jan 2018 17:19:14 +0000 Subject: [PATCH] crypto/qat: fix null auth algo overwrite If auth algorithm is RTE_CRYPTO_AUTH_NULL and digest_length is 0 in the xform and digest pointer is set in the op, then the PMD may overwrite memory at the digest pointer. With this patch the memory is not overwritten. Fixes: db0e952a5c01 ("crypto/qat: add NULL capability") Cc: stable@dpdk.org Signed-off-by: Fiona Trahe Acked-by: Radu Nicolau --- drivers/crypto/qat/qat_crypto.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/qat/qat_crypto.c b/drivers/crypto/qat/qat_crypto.c index 61760b699a..f2a28750ff 100644 --- a/drivers/crypto/qat/qat_crypto.c +++ b/drivers/crypto/qat/qat_crypto.c @@ -1342,7 +1342,9 @@ qat_write_hw_desc_entry(struct rte_crypto_op *op, uint8_t *out_msg, } min_ofs = auth_ofs; - auth_param->auth_res_addr = op->sym->auth.digest.phys_addr; + if (likely(ctx->qat_hash_alg != ICP_QAT_HW_AUTH_ALGO_NULL)) + auth_param->auth_res_addr = + op->sym->auth.digest.phys_addr; } -- 2.20.1