From 4f872116c59a1342dd7ab7165adf05a624480b70 Mon Sep 17 00:00:00 2001 From: Reshma Pattan Date: Tue, 17 Jul 2018 17:44:45 +0100 Subject: [PATCH] test/flow_classify: fix return types UTs should return either TEST_SUCCESS or TEST_FAILED only. They should not return 0, -1 and any other value. Fixes: 9c9befea4f ("test: add flow classify unit tests") CC: stable@dpdk.org Signed-off-by: Reshma Pattan Reviewed-by: Anatoly Burakov --- test/test/test_flow_classify.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/test/test/test_flow_classify.c b/test/test/test_flow_classify.c index fc83b69aee..5f5beeee75 100644 --- a/test/test/test_flow_classify.c +++ b/test/test/test_flow_classify.c @@ -871,32 +871,32 @@ test_flow_classify(void) printf("Line %i: f_create has failed!\n", __LINE__); rte_flow_classifier_free(cls->cls); rte_free(cls); - return -1; + return TEST_FAILED; } printf("Created table_acl for for IPv4 five tuple packets\n"); ret = init_mbufpool(); if (ret) { printf("Line %i: init_mbufpool has failed!\n", __LINE__); - return -1; + return TEST_FAILED; } if (test_invalid_parameters() < 0) - return -1; + return TEST_FAILED; if (test_valid_parameters() < 0) - return -1; + return TEST_FAILED; if (test_invalid_patterns() < 0) - return -1; + return TEST_FAILED; if (test_invalid_actions() < 0) - return -1; + return TEST_FAILED; if (test_query_udp() < 0) - return -1; + return TEST_FAILED; if (test_query_tcp() < 0) - return -1; + return TEST_FAILED; if (test_query_sctp() < 0) - return -1; + return TEST_FAILED; - return 0; + return TEST_SUCCESS; } REGISTER_TEST_COMMAND(flow_classify_autotest, test_flow_classify); -- 2.20.1