From 50ade1a71439a0c30df635c5e2f43e1c2d460ada Mon Sep 17 00:00:00 2001 From: Andy Pei Date: Wed, 22 May 2019 14:44:42 +0800 Subject: [PATCH] net/ipn3ke: delete identical branch Whether the if statement is true or not, the operation is identical. It is unnecessary to check the if statement, so just delete the if statement. Coverity issue: 337928 Fixes: c820468ac99c ("net/ipn3ke: support TM") Cc: stable@dpdk.org Signed-off-by: Andy Pei Acked-by: Rosen Xu --- drivers/net/ipn3ke/ipn3ke_tm.c | 15 ++------------- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/drivers/net/ipn3ke/ipn3ke_tm.c b/drivers/net/ipn3ke/ipn3ke_tm.c index 4bcf3aa932..39c49bc15b 100644 --- a/drivers/net/ipn3ke/ipn3ke_tm.c +++ b/drivers/net/ipn3ke/ipn3ke_tm.c @@ -1541,23 +1541,12 @@ ipn3ke_tm_hierarchy_commit_check(struct rte_eth_dev *dev, NULL, rte_strerror(EINVAL)); } - } else if (n->node_state == - IPN3KE_TM_NODE_STATE_CONFIGURED_DEL) { - if (n->level != IPN3KE_TM_NODE_LEVEL_VT || - n->n_children != 0) { - return -rte_tm_error_set(error, - EINVAL, - RTE_TM_ERROR_TYPE_UNSPECIFIED, - NULL, - rte_strerror(EINVAL)); - } else { - return -rte_tm_error_set(error, + } else if (n->node_state == IPN3KE_TM_NODE_STATE_CONFIGURED_DEL) + return -rte_tm_error_set(error, EINVAL, RTE_TM_ERROR_TYPE_UNSPECIFIED, NULL, rte_strerror(EINVAL)); - } - } } n = tm->h.port_commit_node; -- 2.20.1