From 5230bc4c77cae884eda5ac392887339108a2b763 Mon Sep 17 00:00:00 2001 From: Pablo de Lara Date: Tue, 4 Oct 2016 08:16:34 +0100 Subject: [PATCH] hash: fix free slot check In function rte_hash_cuckoo_insert_mw_tm, while looking for an empty slot, only the first entry in the bucket was being checked, as key_idx array was not being iterated. Fixes: 5fc74c2e146d ("hash: check if slot is empty with key index") Reported-by: Bruce Richardson Signed-off-by: Pablo de Lara Acked-by: Bruce Richardson --- lib/librte_hash/rte_cuckoo_hash_x86.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_hash/rte_cuckoo_hash_x86.h b/lib/librte_hash/rte_cuckoo_hash_x86.h index e16d69cecf..7ffa56f959 100644 --- a/lib/librte_hash/rte_cuckoo_hash_x86.h +++ b/lib/librte_hash/rte_cuckoo_hash_x86.h @@ -53,7 +53,7 @@ rte_hash_cuckoo_insert_mw_tm(struct rte_hash_bucket *prim_bkt, */ for (i = 0; i < RTE_HASH_BUCKET_ENTRIES; i++) { /* Check if slot is available */ - if (likely(prim_bkt->key_idx == EMPTY_SLOT)) { + if (likely(prim_bkt->key_idx[i] == EMPTY_SLOT)) { prim_bkt->signatures[i].current = sig; prim_bkt->signatures[i].alt = alt_hash; prim_bkt->key_idx[i] = new_idx; -- 2.20.1