From 53900e1ae6bbc985934a7647bc1afef83bccea84 Mon Sep 17 00:00:00 2001 From: Viacheslav Ovsiienko Date: Wed, 27 Jan 2021 15:53:05 +0200 Subject: [PATCH] net/mlx5: fix wire vport hint In order to optimize number of hops in the steering tables there was the hint field of source vport in the matcher. If this hint was provided for the wire port the actual vport match, used by kernel, was not set in the matcher metadata register field. This could led to not creating the rule in hardware and E-Switch malfunction if kernel used non-zero metadata value for the wire vport. This patch always sets the match for the vport metadata register value besides the hint. Fixes: aaf34de5d801 ("net/mlx5: add wire vport hint") Cc: stable@dpdk.org Signed-off-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5_flow_dv.c | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c index 95a066f78e..8c11ac306f 100644 --- a/drivers/net/mlx5/mlx5_flow_dv.c +++ b/drivers/net/mlx5/mlx5_flow_dv.c @@ -8662,11 +8662,15 @@ flow_dv_translate_item_port_id(struct rte_eth_dev *dev, void *matcher, priv->pf_bond < 0 && attr->transfer) flow_dv_translate_item_source_vport (matcher, key, priv->vport_id, mask); - else - flow_dv_translate_item_meta_vport - (matcher, key, - priv->vport_meta_tag, - priv->vport_meta_mask); + /* + * We should always set the vport metadata register, + * otherwise the SW steering library can drop + * the rule if wire vport metadata value is not zero, + * it depends on kernel configuration. + */ + flow_dv_translate_item_meta_vport(matcher, key, + priv->vport_meta_tag, + priv->vport_meta_mask); } else { flow_dv_translate_item_source_vport(matcher, key, priv->vport_id, mask); -- 2.20.1