From 606d690548983ef69560c20b21c1431d4ebc0ca2 Mon Sep 17 00:00:00 2001 From: Shiri Kuzin Date: Thu, 20 Feb 2020 14:42:26 +0000 Subject: [PATCH] net/mlx5: fix running without Rx queue When running mlx5_dev_start in mlx5_ethdev the function calls mlx5_dev_configure_rss_reta in order to configure the rxq's. Before mlx5_dev_configure_rss_reta there isn't a check whether there are rxq's and if rxq's are 0 the function fails. For example, this command: /build/app/test-pmd/testpmd -n 4 -w 0000:08:00.0,rx_vec_en=0 -- --burst=64 --mbcache=512 -i --nb-cores=27 --txd=2048 --rxd=2048 --vxlan-gpe-port=6081 --mp-alloc=xbuf --rxq 0 --forward-mode=txonly would fail. In order to fix this issue, we should call mlx5_dev_configure_rss_reta only if we have rxq's. Fixes: 63bd16292c3a ("net/mlx5: support RSS on hairpin") Cc: stable@dpdk.org Reported-by: Sylvain Rodon Signed-off-by: Shiri Kuzin Acked-by: Matan Azrad --- drivers/net/mlx5/mlx5_trigger.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/net/mlx5/mlx5_trigger.c b/drivers/net/mlx5/mlx5_trigger.c index be47df529f..571b7a003c 100644 --- a/drivers/net/mlx5/mlx5_trigger.c +++ b/drivers/net/mlx5/mlx5_trigger.c @@ -280,11 +280,13 @@ mlx5_dev_start(struct rte_eth_dev *dev) rte_net_mlx5_dynf_inline_mask = 1UL << fine_inline; else rte_net_mlx5_dynf_inline_mask = 0; - ret = mlx5_dev_configure_rss_reta(dev); - if (ret) { - DRV_LOG(ERR, "port %u reta config failed: %s", - dev->data->port_id, strerror(rte_errno)); - return -rte_errno; + if (dev->data->nb_rx_queues > 0) { + ret = mlx5_dev_configure_rss_reta(dev); + if (ret) { + DRV_LOG(ERR, "port %u reta config failed: %s", + dev->data->port_id, strerror(rte_errno)); + return -rte_errno; + } } ret = mlx5_txq_start(dev); if (ret) { -- 2.20.1