From 64b7acd861b13d4f1a2b860c448edc99c5d236ef Mon Sep 17 00:00:00 2001 From: Ivan Boule Date: Fri, 29 May 2015 10:56:25 +0200 Subject: [PATCH 1/1] ethdev: add multicast address filtering With the current PMD API, the receipt of multicast packets on a given port can only be enabled by invoking the "rte_eth_allmulticast_enable" function. This method may not work on Virtual Functions in SR-IOV architectures when the host PF driver does not allow such operation on VFs. In such cases, joined multicast addresses must be individually added in the set of multicast addresses that are filtered by the [VF] port. For this purpose, a new function "set_mc_addr_list" is introduced into the set of functions that are exported by a Poll Mode Driver. Signed-off-by: Ivan Boule Acked-by: Stephen Hemminger [Thomas: export new function in .map] Acked-by: Thomas Monjalon --- lib/librte_ether/rte_ethdev.c | 17 +++++++++++++++++ lib/librte_ether/rte_ethdev.h | 26 ++++++++++++++++++++++++++ lib/librte_ether/rte_ether_version.map | 8 ++++++++ 3 files changed, 51 insertions(+) diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c index 5a94654a7c..e13fde5e80 100644 --- a/lib/librte_ether/rte_ethdev.c +++ b/lib/librte_ether/rte_ethdev.c @@ -3627,3 +3627,20 @@ rte_eth_remove_tx_callback(uint8_t port_id, uint16_t queue_id, /* Callback wasn't found. */ return -EINVAL; } + +int +rte_eth_dev_set_mc_addr_list(uint8_t port_id, + struct ether_addr *mc_addr_set, + uint32_t nb_mc_addr) +{ + struct rte_eth_dev *dev; + + if (!rte_eth_dev_is_valid_port(port_id)) { + PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id); + return -ENODEV; + } + + dev = &rte_eth_devices[port_id]; + FUNC_PTR_OR_ERR_RET(*dev->dev_ops->set_mc_addr_list, -ENOTSUP); + return dev->dev_ops->set_mc_addr_list(dev, mc_addr_set, nb_mc_addr); +} diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h index 16dbe00ee6..04c192d827 100644 --- a/lib/librte_ether/rte_ethdev.h +++ b/lib/librte_ether/rte_ethdev.h @@ -1228,6 +1228,10 @@ typedef int (*eth_udp_tunnel_del_t)(struct rte_eth_dev *dev, struct rte_eth_udp_tunnel *tunnel_udp); /**< @internal Delete tunneling UDP info */ +typedef int (*eth_set_mc_addr_list_t)(struct rte_eth_dev *dev, + struct ether_addr *mc_addr_set, + uint32_t nb_mc_addr); +/**< @internal set the list of multicast addresses on an Ethernet device */ #ifdef RTE_NIC_BYPASS @@ -1386,6 +1390,7 @@ struct eth_dev_ops { /** Get current RSS hash configuration. */ rss_hash_conf_get_t rss_hash_conf_get; eth_filter_ctrl_t filter_ctrl; /**< common filter control*/ + eth_set_mc_addr_list_t set_mc_addr_list; /**< set list of mcast addrs */ }; /** @@ -3615,4 +3620,25 @@ int rte_eth_remove_tx_callback(uint8_t port_id, uint16_t queue_id, } #endif +/** + * Set the list of multicast addresses to filter on an Ethernet device. + * + * @param port_id + * The port identifier of the Ethernet device. + * @param mc_addr_set + * The array of multicast addresses to set. Equal to NULL when the function + * is invoked to flush the set of filtered addresses. + * @param nb_mc_addr + * The number of multicast addresses in the *mc_addr_set* array. Equal to 0 + * when the function is invoked to flush the set of filtered addresses. + * @return + * - (0) if successful. + * - (-ENODEV) if *port_id* invalid. + * - (-ENOTSUP) if PMD of *port_id* doesn't support multicast filtering. + * - (-ENOSPC) if *port_id* has not enough multicast filtering resources. + */ +int rte_eth_dev_set_mc_addr_list(uint8_t port_id, + struct ether_addr *mc_addr_set, + uint32_t nb_mc_addr); + #endif /* _RTE_ETHDEV_H_ */ diff --git a/lib/librte_ether/rte_ether_version.map b/lib/librte_ether/rte_ether_version.map index a2d25a61f2..012a82e2c8 100644 --- a/lib/librte_ether/rte_ether_version.map +++ b/lib/librte_ether/rte_ether_version.map @@ -105,3 +105,11 @@ DPDK_2.0 { local: *; }; + +DPDK_2.1 { + global: + + rte_eth_dev_set_mc_addr_list; + + local: *; +} DPDK_2.0; -- 2.20.1