From 64f22b91c6694e71a5163e7f33a55655fd260f90 Mon Sep 17 00:00:00 2001 From: Anatoly Burakov Date: Wed, 7 Apr 2021 15:56:42 +0000 Subject: [PATCH] power: remove redundant close of frequency file Previous fix has addressed the incorrect handling of `base_frequency` file, but has added a use-after-free error due to the fact that all further code paths will lead to an `fclose()` call at the end, so the additional `fclose()` call right after processing the file was unnecessary. Coverity issue: 369901 Fixes: 8a5febaac4f7 ("power: fix P-state base frequency handling") Signed-off-by: Anatoly Burakov Reviewed-by: Liang Ma Acked-by: David Hunt --- lib/librte_power/power_pstate_cpufreq.c | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/librte_power/power_pstate_cpufreq.c b/lib/librte_power/power_pstate_cpufreq.c index 1cb0e4d917..ec745153d3 100644 --- a/lib/librte_power/power_pstate_cpufreq.c +++ b/lib/librte_power/power_pstate_cpufreq.c @@ -220,7 +220,6 @@ power_init_for_setting_freq(struct pstate_power_info *pi) base_ratio = strtoul(buf_base, NULL, POWER_CONVERT_TO_DECIMAL) / BUS_FREQ; - fclose(f_base); } /* Add MSR read to detect turbo status */ -- 2.20.1