From 653c6ed4a12ad40e476a8936b4f463e01acfbf78 Mon Sep 17 00:00:00 2001 From: Zhenghua Zhou Date: Tue, 27 Oct 2020 06:42:52 +0000 Subject: [PATCH] app/testpmd: do not allow dynamic change of core number When the number of forwarding cores changed in runtime, the issue may be encountered: If the nbcore set little than current nbcore, the forwarding thread will still running on the extra cores. Therefore, trying to stop forwarding will hang testpmd, since it will wait for the extra cores to stop. So do not allow to change nbcore number when forwarding is running. Fixes: 0c0db76f42ed ("app/testpmd: separate forward config setup from display") Cc: stable@dpdk.org Signed-off-by: Zhenghua Zhou Acked-by: Ferruh Yigit --- app/test-pmd/config.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index 136f4e5dbe..755d1dfc9c 100644 --- a/app/test-pmd/config.c +++ b/app/test-pmd/config.c @@ -3504,6 +3504,10 @@ set_fwd_lcores_mask(uint64_t lcoremask) void set_fwd_lcores_number(uint16_t nb_lc) { + if (test_done == 0) { + printf("Please stop forwarding first\n"); + return; + } if (nb_lc > nb_cfg_lcores) { printf("nb fwd cores %u > %u (max. number of configured " "lcores) - ignored\n", -- 2.20.1