From 66d485fb50d8de4e78deefebdadc4723c2db2ea2 Mon Sep 17 00:00:00 2001 From: Nithin Dabilpuram Date: Thu, 3 Mar 2022 12:30:41 +0530 Subject: [PATCH] common/cnxk: fix bitmap usage for TM Revert change [1] to return error on case where no slab of free resources is found. That error check break's a case where there is a spare schedule queue to be reused that was just allocated for sake of contiguous static TM nodes. [1] Fixes: 14f7e5d4bf2d ("common/cnxk: add missing checks of return values") Cc: stable@dpdk.org Signed-off-by: Nithin Dabilpuram Acked-by: Jerin Jacob --- drivers/common/cnxk/roc_nix_tm.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/common/cnxk/roc_nix_tm.c b/drivers/common/cnxk/roc_nix_tm.c index 7a17780058..5b70c7bfed 100644 --- a/drivers/common/cnxk/roc_nix_tm.c +++ b/drivers/common/cnxk/roc_nix_tm.c @@ -1042,10 +1042,8 @@ nix_tm_assign_hw_id(struct nix *nix, struct nix_tm_node *parent, return -EFAULT; } - if (!slab) { - if (!plt_bitmap_scan(bmp, &pos, &slab)) - return -ENOENT; - } + if (!slab) + plt_bitmap_scan(bmp, &pos, &slab); if (child->priority == parent->rr_prio && spare_schq != -1) { /* Use spare schq first if present */ -- 2.39.5