From 684e6f4a78307796c45018c77908be4c96999e45 Mon Sep 17 00:00:00 2001 From: Thomas Monjalon Date: Fri, 23 Sep 2016 01:35:39 +0200 Subject: [PATCH] mk: fix verbosity zero Verbosity is considered enabled when $V is not empty. It is a well spread shortcut in makefiles, see git grep '$(if $(*V' So V=0 and V=1 are equivalent. It is fixed by unsetting V when it is 0. A side effect is to fix kernel module compilation verbosity which is set to 0 when V is empty. Reported-by: Ferruh Yigit Signed-off-by: Thomas Monjalon Acked-by: Ferruh Yigit --- mk/rte.sdkroot.mk | 3 +++ mk/rte.vars.mk | 3 +++ 2 files changed, 6 insertions(+) diff --git a/mk/rte.sdkroot.mk b/mk/rte.sdkroot.mk index 55a9d8aeca..04ad523bb4 100644 --- a/mk/rte.sdkroot.mk +++ b/mk/rte.sdkroot.mk @@ -34,6 +34,9 @@ MAKEFLAGS += --no-print-directory # define Q to '@' or not. $(Q) is used to prefix all shell commands to # be executed silently. Q=@ +ifeq '$V' '0' +override V= +endif ifdef V ifeq ("$(origin V)", "command line") Q= diff --git a/mk/rte.vars.mk b/mk/rte.vars.mk index 28982a5f0d..c240a0e2a5 100644 --- a/mk/rte.vars.mk +++ b/mk/rte.vars.mk @@ -46,6 +46,9 @@ endif # define Q to '@' or not. $(Q) is used to prefix all shell commands to # be executed silently. Q=@ +ifeq '$V' '0' +override V= +endif ifdef V ifeq ("$(origin V)", "command line") Q= -- 2.20.1