From 6aba4a036e0bf188f42dc8eee678f89211330fb8 Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Wed, 21 Apr 2021 16:09:29 -0700 Subject: [PATCH] net/bnxt: skip get statistics for stopped queues An application using rte_flow may define a large number of queues but only use a small subset of them at any one time. Since querying the status of each queue requires a request/spin/reply with the firmware, optimize by skipping the request for queues not running. For those queues the statistics will be 0. This cuts the cost of single xstats query in half and has even bigger gain for simple stats query. Signed-off-by: Stephen Hemminger Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_stats.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/bnxt/bnxt_stats.c b/drivers/net/bnxt/bnxt_stats.c index bb4b2eee19..11767e06d0 100644 --- a/drivers/net/bnxt/bnxt_stats.c +++ b/drivers/net/bnxt/bnxt_stats.c @@ -528,6 +528,8 @@ int bnxt_stats_get_op(struct rte_eth_dev *eth_dev, struct bnxt_rx_queue *rxq = bp->rx_queues[i]; struct bnxt_cp_ring_info *cpr = rxq->cp_ring; + if (!rxq->rx_started) + continue; rc = bnxt_hwrm_ctx_qstats(bp, cpr->hw_stats_ctx_id, i, bnxt_stats, 1); if (unlikely(rc)) @@ -543,6 +545,8 @@ int bnxt_stats_get_op(struct rte_eth_dev *eth_dev, struct bnxt_tx_queue *txq = bp->tx_queues[i]; struct bnxt_cp_ring_info *cpr = txq->cp_ring; + if (!txq->tx_started) + continue; rc = bnxt_hwrm_ctx_qstats(bp, cpr->hw_stats_ctx_id, i, bnxt_stats, 0); if (unlikely(rc)) -- 2.20.1