From 6d7046215a3da334bac77d2b06e5ae1c208f3ca4 Mon Sep 17 00:00:00 2001 From: Maxime Coquelin Date: Fri, 22 Apr 2022 11:35:43 +0200 Subject: [PATCH] net/vhost: fix TSO feature default disablement By default, TSO feature should be disabled because it requires application's support to be functional as mentioned in the documentation. However, if "tso" devarg was not specified, the feature did not get disabled. This patch fixes this issue, so that TSO is disabled, even if "tso=0" is not passed as devarg. Fixes: e289400669d5 ("net/vhost: support TSO disabling") Cc: stable@dpdk.org Signed-off-by: Maxime Coquelin Reviewed-by: David Marchand --- drivers/net/vhost/rte_eth_vhost.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/vhost/rte_eth_vhost.c b/drivers/net/vhost/rte_eth_vhost.c index 8a6595504a..a248a65df4 100644 --- a/drivers/net/vhost/rte_eth_vhost.c +++ b/drivers/net/vhost/rte_eth_vhost.c @@ -1654,11 +1654,11 @@ rte_pmd_vhost_probe(struct rte_vdev_device *dev) &open_int, &tso); if (ret < 0) goto out_free; + } - if (tso == 0) { - disable_flags |= (1ULL << VIRTIO_NET_F_HOST_TSO4); - disable_flags |= (1ULL << VIRTIO_NET_F_HOST_TSO6); - } + if (tso == 0) { + disable_flags |= (1ULL << VIRTIO_NET_F_HOST_TSO4); + disable_flags |= (1ULL << VIRTIO_NET_F_HOST_TSO6); } if (rte_kvargs_count(kvlist, ETH_VHOST_LINEAR_BUF) == 1) { -- 2.39.5