From 6d72dce7ed683fe0f9d8670edddb381eb20184b0 Mon Sep 17 00:00:00 2001 From: Tomasz Duszynski Date: Tue, 2 Nov 2021 19:41:32 +0100 Subject: [PATCH] raw/cnxk_bphy: keep leading zero in device name Device naming might be misleading which is especially true if one takes it from lspci output. In order to keep naming consistent keep leading zero in front of pci bus number. Signed-off-by: Tomasz Duszynski Reviewed-by: Jakub Palider Acked-by: Jerin Jacob --- doc/guides/rawdevs/cnxk_bphy.rst | 6 ++++-- drivers/raw/cnxk_bphy/cnxk_bphy.c | 2 +- drivers/raw/cnxk_bphy/cnxk_bphy_cgx.c | 2 +- 3 files changed, 6 insertions(+), 4 deletions(-) diff --git a/doc/guides/rawdevs/cnxk_bphy.rst b/doc/guides/rawdevs/cnxk_bphy.rst index bf7c00e6bc..3cb2175688 100644 --- a/doc/guides/rawdevs/cnxk_bphy.rst +++ b/doc/guides/rawdevs/cnxk_bphy.rst @@ -146,8 +146,10 @@ the raw devices. The rawdev ID of the device can be obtained using invocation of ``rte_rawdev_get_dev_id("NAME:x")`` from the test application, where: - NAME is the desired subsystem: use "BPHY" for regular, and "BPHY_CGX" for - RFOE module, -- x is the device's bus id specified in "bus:device.func" (BDF) format. + RFOE module. +- x is the device's bus id specified in "bus:device.func" (BDF) format. BDF follows convention + used by lspci i.e bus, device and func are specified using respectively two, two and one hex + digit(s). Use this identifier for further rawdev function calls. diff --git a/drivers/raw/cnxk_bphy/cnxk_bphy.c b/drivers/raw/cnxk_bphy/cnxk_bphy.c index 558ebfa85e..349d551839 100644 --- a/drivers/raw/cnxk_bphy/cnxk_bphy.c +++ b/drivers/raw/cnxk_bphy/cnxk_bphy.c @@ -158,7 +158,7 @@ err_desc: static void bphy_rawdev_get_name(char *name, struct rte_pci_device *pci_dev) { - snprintf(name, RTE_RAWDEV_NAME_MAX_LEN, "BPHY:%x:%02x.%x", + snprintf(name, RTE_RAWDEV_NAME_MAX_LEN, "BPHY:%02x:%02x.%x", pci_dev->addr.bus, pci_dev->addr.devid, pci_dev->addr.function); } diff --git a/drivers/raw/cnxk_bphy/cnxk_bphy_cgx.c b/drivers/raw/cnxk_bphy/cnxk_bphy_cgx.c index ade45ab741..0b694e1c03 100644 --- a/drivers/raw/cnxk_bphy/cnxk_bphy_cgx.c +++ b/drivers/raw/cnxk_bphy/cnxk_bphy_cgx.c @@ -28,7 +28,7 @@ static void cnxk_bphy_cgx_format_name(char *name, unsigned int len, struct rte_pci_device *pci_dev) { - snprintf(name, len, "BPHY_CGX:%x:%02x.%x", pci_dev->addr.bus, + snprintf(name, len, "BPHY_CGX:%02x:%02x.%x", pci_dev->addr.bus, pci_dev->addr.devid, pci_dev->addr.function); } -- 2.39.5