From 6efad95f155a8020ffd90321864dd3067fff9e85 Mon Sep 17 00:00:00 2001 From: Slawomir Mrozowicz Date: Wed, 15 Jun 2016 12:33:42 +0200 Subject: [PATCH] app/testpmd: print RSS hash update error Calling rte_eth_dev_rss_hash_update without checking return value. Fixed by handle return value and print out error status. Coverity issue: 119251 Fixes: ce8d561418d4 ("app/testpmd: add port configuration settings") Signed-off-by: Slawomir Mrozowicz Acked-by: Pablo de Lara --- app/test-pmd/cmdline.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index 030beecfd1..9d3e4e80a6 100644 --- a/app/test-pmd/cmdline.c +++ b/app/test-pmd/cmdline.c @@ -1535,6 +1535,7 @@ cmd_config_rss_parsed(void *parsed_result, { struct cmd_config_rss *res = parsed_result; struct rte_eth_rss_conf rss_conf; + int diag; uint8_t i; if (!strcmp(res->value, "all")) @@ -1558,8 +1559,13 @@ cmd_config_rss_parsed(void *parsed_result, return; } rss_conf.rss_key = NULL; - for (i = 0; i < rte_eth_dev_count(); i++) - rte_eth_dev_rss_hash_update(i, &rss_conf); + for (i = 0; i < rte_eth_dev_count(); i++) { + diag = rte_eth_dev_rss_hash_update(i, &rss_conf); + if (diag < 0) + printf("Configuration of RSS hash at ethernet port %d " + "failed with error (%d): %s.\n", + i, -diag, strerror(-diag)); + } } cmdline_parse_token_string_t cmd_config_rss_port = -- 2.20.1