From 6f2dc9c0b496b4c6eb30c6dac59f0ca818903804 Mon Sep 17 00:00:00 2001 From: David Marchand Date: Thu, 1 Oct 2020 09:55:17 +0200 Subject: [PATCH] drivers/common: mark all symbols as internal Now that we have the internal tag, let's avoid confusion with exported symbols in common drivers that were using the experimental tag as a workaround. There is also no need to put internal API symbols in the public stable ABI. Signed-off-by: David Marchand Acked-by: Anoob Joseph Acked-by: Ray Kinsella --- drivers/common/cpt/cpt_pmd_ops_helper.h | 8 +++++--- drivers/common/cpt/rte_common_cpt_version.map | 13 +++---------- drivers/common/mvep/rte_common_mvep_version.map | 2 +- drivers/common/mvep/rte_mvep_common.h | 3 +++ drivers/common/octeontx/octeontx_mbox.h | 5 +++++ .../common/octeontx/rte_common_octeontx_version.map | 2 +- 6 files changed, 18 insertions(+), 15 deletions(-) diff --git a/drivers/common/cpt/cpt_pmd_ops_helper.h b/drivers/common/cpt/cpt_pmd_ops_helper.h index 716ae94c8e..413ca50edd 100644 --- a/drivers/common/cpt/cpt_pmd_ops_helper.h +++ b/drivers/common/cpt/cpt_pmd_ops_helper.h @@ -18,7 +18,7 @@ * @return * - length */ - +__rte_internal int32_t cpt_pmd_ops_helper_get_mlen_direct_mode(void); @@ -29,6 +29,7 @@ cpt_pmd_ops_helper_get_mlen_direct_mode(void); * @return * - length */ +__rte_internal int cpt_pmd_ops_helper_get_mlen_sg_mode(void); @@ -38,6 +39,7 @@ cpt_pmd_ops_helper_get_mlen_sg_mode(void); * @return * - length */ +__rte_internal int cpt_pmd_ops_helper_asym_get_mlen(void); @@ -50,13 +52,13 @@ cpt_pmd_ops_helper_asym_get_mlen(void); * @return * - 0 on success, negative on error */ -__rte_experimental +__rte_internal int cpt_fpm_init(uint64_t *fpm_table_iova); /* * Clear ECC FMUL precomputed table */ -__rte_experimental +__rte_internal void cpt_fpm_clear(void); #endif /* _CPT_PMD_OPS_HELPER_H_ */ diff --git a/drivers/common/cpt/rte_common_cpt_version.map b/drivers/common/cpt/rte_common_cpt_version.map index 4d85021a87..b4080e0f8c 100644 --- a/drivers/common/cpt/rte_common_cpt_version.map +++ b/drivers/common/cpt/rte_common_cpt_version.map @@ -1,18 +1,11 @@ -DPDK_21 { +INTERNAL { global: + cpt_fpm_clear; + cpt_fpm_init; cpt_pmd_ops_helper_asym_get_mlen; cpt_pmd_ops_helper_get_mlen_direct_mode; cpt_pmd_ops_helper_get_mlen_sg_mode; local: *; }; - -EXPERIMENTAL { - global: - - cpt_fpm_clear; - cpt_fpm_init; - - local: *; -}; diff --git a/drivers/common/mvep/rte_common_mvep_version.map b/drivers/common/mvep/rte_common_mvep_version.map index e5af82c61d..cbac7bfa8d 100644 --- a/drivers/common/mvep/rte_common_mvep_version.map +++ b/drivers/common/mvep/rte_common_mvep_version.map @@ -1,4 +1,4 @@ -DPDK_21 { +INTERNAL { global: rte_mvep_deinit; diff --git a/drivers/common/mvep/rte_mvep_common.h b/drivers/common/mvep/rte_mvep_common.h index 0593cefcd2..b10540316b 100644 --- a/drivers/common/mvep/rte_mvep_common.h +++ b/drivers/common/mvep/rte_mvep_common.h @@ -5,6 +5,7 @@ #ifndef __RTE_MVEP_COMMON_H__ #define __RTE_MVEP_COMMON_H__ +#include #include enum mvep_module_type { @@ -15,7 +16,9 @@ enum mvep_module_type { MVEP_MOD_T_LAST }; +__rte_internal int rte_mvep_init(enum mvep_module_type module, struct rte_kvargs *kvlist); +__rte_internal int rte_mvep_deinit(enum mvep_module_type module); #endif /* __RTE_MVEP_COMMON_H__ */ diff --git a/drivers/common/octeontx/octeontx_mbox.h b/drivers/common/octeontx/octeontx_mbox.h index e56719cb85..706b198f6e 100644 --- a/drivers/common/octeontx/octeontx_mbox.h +++ b/drivers/common/octeontx/octeontx_mbox.h @@ -35,11 +35,16 @@ struct octeontx_mbox_hdr { uint8_t res_code; /* Functional layer response code */ }; +__rte_internal int octeontx_mbox_init(void); void octeontx_set_global_domain(uint16_t global_domain); +__rte_internal uint16_t octeontx_get_global_domain(void); +__rte_internal int octeontx_mbox_set_ram_mbox_base(uint8_t *ram_mbox_base, uint16_t domain); +__rte_internal int octeontx_mbox_set_reg(uint8_t *reg, uint16_t domain); +__rte_internal int octeontx_mbox_send(struct octeontx_mbox_hdr *hdr, void *txdata, uint16_t txlen, void *rxdata, uint16_t rxlen); diff --git a/drivers/common/octeontx/rte_common_octeontx_version.map b/drivers/common/octeontx/rte_common_octeontx_version.map index 30f3fa65e0..049f66b331 100644 --- a/drivers/common/octeontx/rte_common_octeontx_version.map +++ b/drivers/common/octeontx/rte_common_octeontx_version.map @@ -1,4 +1,4 @@ -DPDK_21 { +INTERNAL { global: octeontx_get_global_domain; -- 2.20.1