From 7385d1c4b4bfdd1f276f088d4b40f2aee4f8d042 Mon Sep 17 00:00:00 2001 From: Fiona Trahe Date: Tue, 22 May 2018 11:33:30 +0100 Subject: [PATCH] compressdev: clarify when private xform can be cleared As the private_xform data can be shared by many operations and across queue_pairs, it would be performance impacting for PMDs to track inflights associated with one. It makes more sense to push the responsibility to the application to keep track of its usage and only delete the private_xform when there are no more ops using it. Signed-off-by: Fiona Trahe Acked-by: Pablo de Lara --- lib/librte_compressdev/rte_compressdev.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/librte_compressdev/rte_compressdev.h b/lib/librte_compressdev/rte_compressdev.h index c86035f149..5b4fca4dcb 100644 --- a/lib/librte_compressdev/rte_compressdev.h +++ b/lib/librte_compressdev/rte_compressdev.h @@ -516,6 +516,8 @@ rte_compressdev_private_xform_create(uint8_t dev_id, /** * This should clear the private_xform and return it to the device's mempool. + * It is the application's responsibility to ensure that private_xform data + * is not cleared while there are still in-flight operations using it. * * @param dev_id * Compress device identifier @@ -527,7 +529,6 @@ rte_compressdev_private_xform_create(uint8_t dev_id, * - 0 if successful * - <0 in error cases * - Returns -EINVAL if input parameters are invalid. - * - Returns -EBUSY if can't free private_xform due to inflight operations */ int __rte_experimental rte_compressdev_private_xform_free(uint8_t dev_id, void *private_xform); -- 2.20.1