From 73bd0ad5936de7a3152850b22f0d08e5c7bd1f5a Mon Sep 17 00:00:00 2001 From: Herakliusz Lipiec Date: Thu, 18 Jul 2019 15:44:48 +0100 Subject: [PATCH] net/i40e: fix MAC removal check Add return value check for i40e_vsi_delete_mac call in rte_pmd_i40e_remove_vf_mac_addr as per coverity issue. Coverity issue: 277224 Fixes: e0cb96204b71 ("net/i40e: add support for representor ports") Cc: stable@dpdk.org Signed-off-by: Herakliusz Lipiec Acked-by: Beilei Xing --- drivers/net/i40e/rte_pmd_i40e.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/i40e/rte_pmd_i40e.c b/drivers/net/i40e/rte_pmd_i40e.c index 24281c2938..4c3c7088a0 100644 --- a/drivers/net/i40e/rte_pmd_i40e.c +++ b/drivers/net/i40e/rte_pmd_i40e.c @@ -581,6 +581,7 @@ rte_pmd_i40e_remove_vf_mac_addr(uint16_t port, uint16_t vf_id, struct i40e_pf_vf *vf; struct i40e_vsi *vsi; struct i40e_pf *pf; + int ret; if (i40e_validate_mac_addr((u8 *)mac_addr) != I40E_SUCCESS) return -EINVAL; @@ -609,8 +610,9 @@ rte_pmd_i40e_remove_vf_mac_addr(uint16_t port, uint16_t vf_id, rte_ether_addr_copy(&null_mac_addr, &vf->mac_addr); /* Remove the mac */ - i40e_vsi_delete_mac(vsi, mac_addr); - + ret = i40e_vsi_delete_mac(vsi, mac_addr); + if (ret != I40E_SUCCESS) + return ret; return 0; } -- 2.20.1