From 75b3dddf95ea0d5a1356115f748e1cc43de67886 Mon Sep 17 00:00:00 2001 From: Chaitanya Babu Talluri Date: Wed, 25 Sep 2019 07:31:34 +0100 Subject: [PATCH] examples/fips_validation: fix null dereferences One issue caught by Coverity 343408 *deref_parm: Directly dereferencing parameter val->val. In writeback_tdes_hex_str(), tmp_val is initialised to null. tmp_val.val is updated only if keys are found. If keys are not found,it doesn't fails but continues to invoke writeback_hex_str(),where val->val is accessed without null check. The fix is to return the error, if keys are not found in writeback_tdes_hex_str(). Coverity issue: 343408 Fixes: 527cbf3d5e ("examples/fips_validation: support TDES parsing") Cc: stable@dpdk.org Signed-off-by: Chaitanya Babu Talluri Acked-by: Akhil Goyal --- examples/fips_validation/fips_validation_tdes.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/examples/fips_validation/fips_validation_tdes.c b/examples/fips_validation/fips_validation_tdes.c index 15ee434e14..2b262c9a02 100644 --- a/examples/fips_validation/fips_validation_tdes.c +++ b/examples/fips_validation/fips_validation_tdes.c @@ -212,6 +212,8 @@ writeback_tdes_hex_str(const char *key, char *dst, struct fips_val *val) tmp_val.val = val->val + 8; else if (strstr(key, KEY3_STR)) tmp_val.val = val->val + 16; + else + return -EINVAL; return writeback_hex_str(key, dst, &tmp_val); } -- 2.20.1