From 7601d32ed3a07d2c341095aa3a47b72e78b12f6a Mon Sep 17 00:00:00 2001 From: =?utf8?q?Micha=C5=82=20Miros=C5=82aw?= Date: Wed, 18 Jan 2017 20:32:51 +0100 Subject: [PATCH] acl: remove invalid test MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit rte_acl_add_rules() has no way of checking rule size. This was hidden because the test effectively checked that adding a rule with userdata == 0 failed. Signed-off-by: Michał Mirosław Acked-by: Konstantin Ananyev --- app/test/test_acl.c | 20 -------------------- 1 file changed, 20 deletions(-) diff --git a/app/test/test_acl.c b/app/test/test_acl.c index 28955f08a9..be744ec23d 100644 --- a/app/test/test_acl.c +++ b/app/test/test_acl.c @@ -1515,26 +1515,6 @@ test_invalid_parameters(void) /* free ACL context */ rte_acl_free(acx); - /* set wrong rule_size so that adding any rules would fail */ - param.rule_size = RTE_ACL_IPV4VLAN_RULE_SZ + 4; - acx = rte_acl_create(¶m); - if (acx == NULL) { - printf("Line %i: ACL context creation failed!\n", __LINE__); - return -1; - } - - /* try adding a rule with size different from context rule_size */ - result = rte_acl_ipv4vlan_add_rules(acx, &rule, 1); - if (result == 0) { - printf("Line %i: Adding an invalid sized rule " - "should have failed!\n", __LINE__); - rte_acl_free(acx); - return -1; - } - - /* free ACL context */ - rte_acl_free(acx); - /** * rte_acl_ipv4vlan_build -- 2.20.1