From 788e7ff29cf73429e749d5e26a30cbfb80051cc6 Mon Sep 17 00:00:00 2001 From: Ferruh Yigit Date: Thu, 8 Feb 2018 12:08:03 +0000 Subject: [PATCH] app/testpmd: enable CRC strip without capability check Some hardware doesn't support disabling CRC strip. In techboard it has been decided to enable CRC strip always. The testpmd update in commit 8b9bd0efe0b6, enables CRC strip only if PMD reports CRC strip capability. Not all PMDs updated to report CRC strip. For the PMDs not reporting CRC strip testpmd behavior changed and disabling CRC strip for them. And this may generate error for PMDs that doesn't support disabling CRC strip. Removing capability check for this release. In long term there can be option to remove CRC strip flag completely or adding a new flag to let PMD say disabling is not supported. Fixes: 8b9bd0efe0b6 ("app/testpmd: disable Rx VLAN offloads by default") Signed-off-by: Ferruh Yigit Acked-by: Konstantin Ananyev --- app/test-pmd/testpmd.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index 46dc22c944..4c0e2586c2 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -694,10 +694,6 @@ init_config(void) DEV_TX_OFFLOAD_MBUF_FAST_FREE)) port->dev_conf.txmode.offloads &= ~DEV_TX_OFFLOAD_MBUF_FAST_FREE; - if (!(port->dev_info.rx_offload_capa & - DEV_RX_OFFLOAD_CRC_STRIP)) - port->dev_conf.rxmode.offloads &= - ~DEV_RX_OFFLOAD_CRC_STRIP; if (numa_support) { if (port_numa[pid] != NUMA_NO_CONFIG) port_per_socket[port_numa[pid]]++; -- 2.20.1