From 78a5545ef92b48553be4a244514a2514ca9b09b0 Mon Sep 17 00:00:00 2001 From: "Min Hu (Connor)" Date: Thu, 29 Apr 2021 08:50:46 +0800 Subject: [PATCH] examples/flow_classify: fix NUMA check of port and core According to the comments and logging, the author just hope user to use the core and device which are in the same numa node for optimal performance. If not, A warning gives out. For example in flow_classify: ./build/flow_classify -a 0000:7d:00.1 -l 93 Here: 0000:7d:00.1 is on numa node 0. core 93 is on numa node 3. The two are not in same numa node, but no warning gives out in old codes when device is on node 0. This patch includes the node 0 in the check. Fixes: bab16ddaf2c1 ("examples/flow_classify: add sample application") Cc: stable@dpdk.org Signed-off-by: Min Hu (Connor) Tested-by: Bernard Iremonger Acked-by: Bernard Iremonger Reviewed-by: Ferruh Yigit --- examples/flow_classify/flow_classify.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/flow_classify/flow_classify.c b/examples/flow_classify/flow_classify.c index 5c3e111cfa..94c1553648 100644 --- a/examples/flow_classify/flow_classify.c +++ b/examples/flow_classify/flow_classify.c @@ -284,7 +284,7 @@ lcore_main(struct flow_classifier *cls_app) * for best performance. */ RTE_ETH_FOREACH_DEV(port) - if (rte_eth_dev_socket_id(port) > 0 && + if (rte_eth_dev_socket_id(port) >= 0 && rte_eth_dev_socket_id(port) != (int)rte_socket_id()) { printf("\n\n"); printf("WARNING: port %u is on remote NUMA node\n", -- 2.20.1