From 79fc1c531e0ae8a1f750639c82f7272d3117a220 Mon Sep 17 00:00:00 2001 From: Ajit Khaparde Date: Tue, 4 Jan 2022 14:08:22 +0530 Subject: [PATCH] net/bnxt: fix crash by validating pointer Validate the pointers in rxq before accessing them. Otherwise it can cause a segfault. Fixes: 657c2a7f1dd4 ("net/bnxt: create aggregation rings when needed") Cc: stable@dpdk.org Signed-off-by: Ajit Khaparde Reviewed-by: Kalesh AP Reviewed-by: Somnath Kotur --- drivers/net/bnxt/bnxt_rxq.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/bnxt/bnxt_rxq.c b/drivers/net/bnxt/bnxt_rxq.c index 9f1d1d4dba..cd3bb1446f 100644 --- a/drivers/net/bnxt/bnxt_rxq.c +++ b/drivers/net/bnxt/bnxt_rxq.c @@ -214,7 +214,9 @@ void bnxt_rx_queue_release_mbufs(struct bnxt_rx_queue *rxq) } } /* Free up mbufs in Agg ring */ - if (!bnxt_need_agg_ring(rxq->bp->eth_dev)) + if (rxq->bp == NULL || + rxq->bp->eth_dev == NULL || + !bnxt_need_agg_ring(rxq->bp->eth_dev)) return; sw_ring = rxq->rx_ring->ag_buf_ring; -- 2.39.5