From 7a0ac7cdb454ea83c258cc5817a18c28787ae161 Mon Sep 17 00:00:00 2001 From: Gage Eads Date: Thu, 20 Jun 2019 14:02:27 -0500 Subject: [PATCH] service: promote experimental functions to stable The functions rte_service_may_be_active(), rte_service_lcore_attr_get(), and rte_service_attr_reset_all() were introduced nearly a year ago in DPDK 18.08. They can be considered non-experimental for the 19.08 release. rte_service_may_be_active() is used by the sw PMD, and this commit allows it to not need any experimental API. Signed-off-by: Gage Eads --- drivers/event/sw/Makefile | 1 - drivers/event/sw/meson.build | 1 - lib/librte_eal/common/include/rte_service.h | 9 --------- lib/librte_eal/rte_eal_version.map | 6 +++--- 4 files changed, 3 insertions(+), 14 deletions(-) diff --git a/drivers/event/sw/Makefile b/drivers/event/sw/Makefile index 81236a392a..c6600e8367 100644 --- a/drivers/event/sw/Makefile +++ b/drivers/event/sw/Makefile @@ -7,7 +7,6 @@ include $(RTE_SDK)/mk/rte.vars.mk LIB = librte_pmd_sw_event.a # build flags -CFLAGS += -DALLOW_EXPERIMENTAL_API CFLAGS += -O3 CFLAGS += $(WERROR_FLAGS) # for older GCC versions, allow us to initialize an event using diff --git a/drivers/event/sw/meson.build b/drivers/event/sw/meson.build index 30d2216476..985012219b 100644 --- a/drivers/event/sw/meson.build +++ b/drivers/event/sw/meson.build @@ -1,7 +1,6 @@ # SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2017 Intel Corporation -allow_experimental_apis = true sources = files('sw_evdev_scheduler.c', 'sw_evdev_selftest.c', 'sw_evdev_worker.c', diff --git a/lib/librte_eal/common/include/rte_service.h b/lib/librte_eal/common/include/rte_service.h index 8b4de551ec..ed5b65e0d2 100644 --- a/lib/librte_eal/common/include/rte_service.h +++ b/lib/librte_eal/common/include/rte_service.h @@ -162,9 +162,6 @@ int32_t rte_service_runstate_set(uint32_t id, uint32_t runstate); int32_t rte_service_runstate_get(uint32_t id); /** - * @warning - * @b EXPERIMENTAL: this API may change, or be removed, without prior notice - * * This function returns whether the service may be currently executing on * at least one lcore, or definitely is not. This function can be used to * determine if, after setting the service runstate to stopped, the service @@ -178,7 +175,6 @@ int32_t rte_service_runstate_get(uint32_t id); * @retval 0 Service is not running on any lcore * @retval -EINVAL Invalid service id */ -__rte_experimental int32_t rte_service_may_be_active(uint32_t id); @@ -390,9 +386,6 @@ int32_t rte_service_attr_reset_all(uint32_t id); #define RTE_SERVICE_LCORE_ATTR_LOOPS 0 /** - * @warning - * @b EXPERIMENTAL: this API may change without prior notice - * * Get an attribute from a service core. * * @param lcore Id of the service core. @@ -402,7 +395,6 @@ int32_t rte_service_attr_reset_all(uint32_t id); * -EINVAL Invalid lcore, attr_id or attr_value was NULL. * -ENOTSUP lcore is not a service core. */ -__rte_experimental int32_t rte_service_lcore_attr_get(uint32_t lcore, uint32_t attr_id, uint64_t *attr_value); @@ -418,7 +410,6 @@ rte_service_lcore_attr_get(uint32_t lcore, uint32_t attr_id, * -EINVAL Invalid service id provided * -ENOTSUP lcore is not a service core. */ -__rte_experimental int32_t rte_service_lcore_attr_reset_all(uint32_t lcore); diff --git a/lib/librte_eal/rte_eal_version.map b/lib/librte_eal/rte_eal_version.map index d0ee67dbfd..1892d9ea94 100644 --- a/lib/librte_eal/rte_eal_version.map +++ b/lib/librte_eal/rte_eal_version.map @@ -305,6 +305,9 @@ DPDK_19.08 { rte_mcfg_tailq_write_lock; rte_mcfg_tailq_write_unlock; rte_rand; + rte_service_lcore_attr_get; + rte_service_lcore_attr_reset_all; + rte_service_may_be_active; rte_srand; } DPDK_19.05; @@ -398,9 +401,6 @@ EXPERIMENTAL { rte_option_register; rte_rand_max; rte_realloc_socket; - rte_service_lcore_attr_get; - rte_service_lcore_attr_reset_all; - rte_service_may_be_active; # added in 19.08 rte_lcore_cpuset; -- 2.20.1