From 7a9b2b099893787ec01abb8f76986f5f18f9205a Mon Sep 17 00:00:00 2001 From: Maxime Leroy Date: Mon, 2 Sep 2013 17:07:55 +0200 Subject: [PATCH] igb/ixgbe: ETH_MQ_RX_NONE should disable RSS As explained in rte_ethdev.h, ETH_MQ_RX_NONE allows to not choose RSS, DCB or VMDQ mode. But the igb/ixgbe code always silently select the RSS mode with ETH_MQ_RX_NONE. This patch fixes this incoherence between the API and the implementation. Signed-off-by: Maxime Leroy Acked-by: Ivan Boule --- lib/librte_pmd_e1000/igb_rxtx.c | 4 ++-- lib/librte_pmd_ixgbe/ixgbe_rxtx.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/librte_pmd_e1000/igb_rxtx.c b/lib/librte_pmd_e1000/igb_rxtx.c index 42955397d1..7e7bd4b854 100644 --- a/lib/librte_pmd_e1000/igb_rxtx.c +++ b/lib/librte_pmd_e1000/igb_rxtx.c @@ -1755,8 +1755,6 @@ igb_dev_mq_rx_configure(struct rte_eth_dev *dev) */ if (dev->data->nb_rx_queues > 1) switch (dev->data->dev_conf.rxmode.mq_mode) { - case ETH_MQ_RX_NONE: - /* if mq_mode not assign, we use rss mode.*/ case ETH_MQ_RX_RSS: igb_rss_configure(dev); break; @@ -1764,6 +1762,8 @@ igb_dev_mq_rx_configure(struct rte_eth_dev *dev) /*Configure general VMDQ only RX parameters*/ igb_vmdq_rx_hw_configure(dev); break; + case ETH_MQ_RX_NONE: + /* if mq_mode is none, disable rss mode.*/ default: igb_rss_disable(dev); break; diff --git a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c index d5775807ea..b63aefe136 100644 --- a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c +++ b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c @@ -3228,8 +3228,6 @@ ixgbe_dev_mq_rx_configure(struct rte_eth_dev *dev) */ if (dev->data->nb_rx_queues > 1) switch (dev->data->dev_conf.rxmode.mq_mode) { - case ETH_MQ_RX_NONE: - /* if mq_mode not assign, we use rss mode.*/ case ETH_MQ_RX_RSS: ixgbe_rss_configure(dev); break; @@ -3242,6 +3240,8 @@ ixgbe_dev_mq_rx_configure(struct rte_eth_dev *dev) ixgbe_vmdq_rx_hw_configure(dev); break; + case ETH_MQ_RX_NONE: + /* if mq_mode is none, disable rss mode.*/ default: ixgbe_rss_disable(dev); } else -- 2.20.1