From 7bb4b07057a7c129ce7eec65af56e0bfb7f675b5 Mon Sep 17 00:00:00 2001 From: Yong Wang Date: Wed, 30 Nov 2016 07:32:09 -0500 Subject: [PATCH] net/qede: fix resource leak Current code does not close 'fd' on function exit, leaking resources. Fixes: 2ea6f76aff40 ("qede: add core driver") Signed-off-by: Yong Wang Acked-by: Harish Patil --- drivers/net/qede/qede_main.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/qede/qede_main.c b/drivers/net/qede/qede_main.c index ab22409a1f..b666e1c7e0 100644 --- a/drivers/net/qede/qede_main.c +++ b/drivers/net/qede/qede_main.c @@ -137,6 +137,7 @@ static int qed_load_firmware_data(struct ecore_dev *edev) if (fstat(fd, &st) < 0) { DP_NOTICE(edev, false, "Can't stat firmware file\n"); + close(fd); return -1; } @@ -158,9 +159,11 @@ static int qed_load_firmware_data(struct ecore_dev *edev) if (edev->fw_len < 104) { DP_NOTICE(edev, false, "Invalid fw size: %" PRIu64 "\n", edev->fw_len); + close(fd); return -EINVAL; } + close(fd); return 0; } #endif -- 2.20.1