From 7bc56bd04c249a9154165f4dda58e27e958aa621 Mon Sep 17 00:00:00 2001 From: Thomas Monjalon Date: Tue, 9 Mar 2021 10:48:33 +0100 Subject: [PATCH] net/mlx4: enable debug logs dynamically The macro DEBUG was doing nothing if not compiled with RTE_LIBRTE_MLX4_DEBUG. As it is not used in the data path, it can be always enabled at compilation time. Then it can be enabled at runtime with: --log-level pmd.net.mlx4:debug Signed-off-by: Thomas Monjalon Acked-by: Matan Azrad --- drivers/net/mlx4/mlx4_utils.h | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/net/mlx4/mlx4_utils.h b/drivers/net/mlx4/mlx4_utils.h index b8769562ab..fca21fd79c 100644 --- a/drivers/net/mlx4/mlx4_utils.h +++ b/drivers/net/mlx4/mlx4_utils.h @@ -52,14 +52,13 @@ pmd_drv_log_basename(const char *s) __LINE__, \ __func__, \ RTE_FMT_TAIL(__VA_ARGS__,))) -#define DEBUG(...) PMD_DRV_LOG(DEBUG, __VA_ARGS__) #define MLX4_ASSERT(exp) RTE_VERIFY(exp) #define claim_zero(...) MLX4_ASSERT((__VA_ARGS__) == 0) #else /* RTE_LIBRTE_MLX4_DEBUG */ /* - * Like MLX4_ASSERT(), DEBUG() becomes a no-op and claim_zero() does not perform + * Like MLX4_ASSERT(), claim_zero() does not perform * any check when debugging is disabled. */ @@ -68,12 +67,12 @@ pmd_drv_log_basename(const char *s) RTE_FMT(MLX4_DRIVER_NAME ": " \ RTE_FMT_HEAD(__VA_ARGS__,) "\n", \ RTE_FMT_TAIL(__VA_ARGS__,))) -#define DEBUG(...) (void)0 #define MLX4_ASSERT(exp) RTE_ASSERT(exp) #define claim_zero(...) (__VA_ARGS__) #endif /* RTE_LIBRTE_MLX4_DEBUG */ +#define DEBUG(...) PMD_DRV_LOG(DEBUG, __VA_ARGS__) #define INFO(...) PMD_DRV_LOG(INFO, __VA_ARGS__) #define WARN(...) PMD_DRV_LOG(WARNING, __VA_ARGS__) #define ERROR(...) PMD_DRV_LOG(ERR, __VA_ARGS__) -- 2.20.1