From 7f109dbac5b181593f5bcd64cf891137e7c5a9cb Mon Sep 17 00:00:00 2001 From: Daniel Mrzyglod Date: Thu, 10 Aug 2017 11:12:14 +0200 Subject: [PATCH] net/i40e: fix return code not checked Calling i40e_vsi_delete_mac without checking return value (as is done elsewhere 5 out of 6 times) Coverity issue: 140735 Fixes: 43c89d5a4fde ("net/i40e: set VF MAC from PF") Signed-off-by: Daniel Mrzyglod Reviewed-by: Ferruh Yigit --- drivers/net/i40e/rte_pmd_i40e.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/i40e/rte_pmd_i40e.c b/drivers/net/i40e/rte_pmd_i40e.c index f12b7f4a19..950a0d6a20 100644 --- a/drivers/net/i40e/rte_pmd_i40e.c +++ b/drivers/net/i40e/rte_pmd_i40e.c @@ -591,7 +591,9 @@ rte_pmd_i40e_set_vf_mac_addr(uint8_t port, uint16_t vf_id, /* Remove all existing mac */ TAILQ_FOREACH_SAFE(f, &vsi->mac_list, next, temp) - i40e_vsi_delete_mac(vsi, &f->mac_info.mac_addr); + if (i40e_vsi_delete_mac(vsi, &f->mac_info.mac_addr) + != I40E_SUCCESS) + PMD_DRV_LOG(WARNING, "Delete MAC failed"); return 0; } -- 2.20.1