From 7fef9ef11ff790e2ea67fc0411d64a7e0457d375 Mon Sep 17 00:00:00 2001 From: Yogesh Jangra Date: Thu, 22 Oct 2020 07:01:52 -0400 Subject: [PATCH] examples/pipeline: fix help command This patch has the changes to list all supported commands and fix supported commands help details. Fixes: 5074e1d55107 ("examples/pipeline: add configuration commands") Signed-off-by: Yogesh Jangra Acked-by: Cristian Dumitrescu --- examples/pipeline/cli.c | 31 ++++++++++++++++++++++--------- 1 file changed, 22 insertions(+), 9 deletions(-) diff --git a/examples/pipeline/cli.c b/examples/pipeline/cli.c index 5800cc98ed..8ac6b3f5ff 100644 --- a/examples/pipeline/cli.c +++ b/examples/pipeline/cli.c @@ -480,7 +480,7 @@ cmd_pipeline_create(char **tokens, static const char cmd_pipeline_port_in_help[] = "pipeline port in \n" " link rxq bsz \n" -" source \n"; +" | source \n"; static void cmd_pipeline_port_in(char **tokens, @@ -1163,7 +1163,18 @@ cmd_help(char **tokens, if (n_tokens == 0) { snprintf(out, out_size, - "Type 'help ' for command details.\n\n"); + "Type 'help ' for command details.\n\n" + "List of commands:\n" + "\tmempool\n" + "\tlink\n" + "\tpipeline create\n" + "\tpipeline port in\n" + "\tpipeline port out\n" + "\tpipeline build\n" + "\tpipeline table update\n" + "\tpipeline stats\n" + "\tthread pipeline enable\n" + "\tthread pipeline disable\n\n"); return; } @@ -1178,20 +1189,20 @@ cmd_help(char **tokens, } if ((strcmp(tokens[0], "pipeline") == 0) && - ((n_tokens == 1) && (strcmp(tokens[2], "create")) == 0)) { + (n_tokens == 2) && (strcmp(tokens[1], "create") == 0)) { snprintf(out, out_size, "\n%s\n", cmd_pipeline_create_help); return; } if ((strcmp(tokens[0], "pipeline") == 0) && - (strcmp(tokens[1], "port") == 0)) { - if ((n_tokens == 3) && (strcmp(tokens[2], "in")) == 0) { + (n_tokens == 3) && (strcmp(tokens[1], "port") == 0)) { + if (strcmp(tokens[2], "in") == 0) { snprintf(out, out_size, "\n%s\n", cmd_pipeline_port_in_help); return; } - if ((n_tokens == 3) && (strcmp(tokens[2], "out")) == 0) { + if (strcmp(tokens[2], "out") == 0) { snprintf(out, out_size, "\n%s\n", cmd_pipeline_port_out_help); return; @@ -1199,20 +1210,22 @@ cmd_help(char **tokens, } if ((strcmp(tokens[0], "pipeline") == 0) && - ((n_tokens >= 2) && (strcmp(tokens[2], "build")) == 0)) { + (n_tokens == 2) && (strcmp(tokens[1], "build") == 0)) { snprintf(out, out_size, "\n%s\n", cmd_pipeline_build_help); return; } if ((strcmp(tokens[0], "pipeline") == 0) && - ((n_tokens >= 2) && (strcmp(tokens[2], "table")) == 0)) { + (n_tokens == 3) && + (strcmp(tokens[1], "table") == 0) && + (strcmp(tokens[2], "update") == 0)) { snprintf(out, out_size, "\n%s\n", cmd_pipeline_table_update_help); return; } if ((strcmp(tokens[0], "pipeline") == 0) && - ((n_tokens >= 2) && (strcmp(tokens[2], "stats")) == 0)) { + (n_tokens == 2) && (strcmp(tokens[1], "stats") == 0)) { snprintf(out, out_size, "\n%s\n", cmd_pipeline_stats_help); return; } -- 2.20.1