From 80cd38e1b530973926c007d65a84600e8c27740d Mon Sep 17 00:00:00 2001 From: Hongbo Zheng Date: Tue, 9 Jun 2020 16:44:15 +0800 Subject: [PATCH] net/hns3: ignore function return on reset error path There is a coverity defect related "Unchecked return value". The internal static hns3_reset_err_handle function is reset error process of hns3 PMD driver. If failure in reset process, it does not mean that the network port is completely unavailable, so the command interface between driver and firmware still needs to be initialized. Regardless of whether the execution of the function named hns3_cmd_init is successful or not, the next process after execution must be continued, so there is no need to check the return value. If hns3_cmd_init fails to execute, there will be corresponding log information inside hns3_cmd_init. This patch adds '(void)' Type conversion to avoid coverity warning. Coverity issue: 349934 Fixes: 2790c6464725 ("net/hns3: support device reset") Cc: stable@dpdk.org Signed-off-by: Hongbo Zheng Signed-off-by: Wei Hu (Xavier) --- drivers/net/hns3/hns3_intr.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/net/hns3/hns3_intr.c b/drivers/net/hns3/hns3_intr.c index 9953a1d98e..46d617c68e 100644 --- a/drivers/net/hns3/hns3_intr.c +++ b/drivers/net/hns3/hns3_intr.c @@ -882,8 +882,14 @@ hns3_reset_err_handle(struct hns3_adapter *hns) return true; } + /* + * Failure to reset does not mean that the network port is + * completely unavailable, so cmd still needs to be initialized. + * Regardless of whether the execution is successful or not, the + * flow after execution must be continued. + */ if (rte_atomic16_read(&hw->reset.disable_cmd)) - hns3_cmd_init(hw); + (void)hns3_cmd_init(hw); reset_fail: hw->reset.attempts = 0; hw->reset.stats.fail_cnt++; -- 2.20.1