From 815037b92b3437754183fb256a967a7e82d3820a Mon Sep 17 00:00:00 2001 From: Huaibin Wang Date: Fri, 19 Oct 2018 11:45:21 +0200 Subject: [PATCH] net/i40e: keep promiscuous on if allmulticast is enabled Promisc should not be disabled if the all multicast mode is enabled. Patch keeps the promiscuous on if all multicast mode is on, this behavior is also consistent with the implementation done on ixgbe pmd. Cc: stable@dpdk.org Signed-off-by: Huaibin Wang Signed-off-by: Laurent Hardy Acked-by: Qi Zhang --- drivers/net/i40e/i40e_ethdev.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index f7a685c8c0..6c503debc3 100644 --- a/drivers/net/i40e/i40e_ethdev.c +++ b/drivers/net/i40e/i40e_ethdev.c @@ -2587,6 +2587,10 @@ i40e_dev_promiscuous_disable(struct rte_eth_dev *dev) if (status != I40E_SUCCESS) PMD_DRV_LOG(ERR, "Failed to disable unicast promiscuous"); + /* must remain in all_multicast mode */ + if (dev->data->all_multicast == 1) + return; + status = i40e_aq_set_vsi_multicast_promiscuous(hw, vsi->seid, false, NULL); if (status != I40E_SUCCESS) -- 2.20.1