From 82a9eab70d80741177fb934d37e6b28d7e22d1e1 Mon Sep 17 00:00:00 2001 From: Kevin Traynor Date: Tue, 5 Mar 2019 16:30:38 +0000 Subject: [PATCH] net/i40e: fix negative check on unsigned queue pairs Fix the check and associated log. Also, fix a typo in other log. Fixes: 03d478e9609d ("net/i40e: support PF respond VF request more queues") Cc: stable@dpdk.org Signed-off-by: Kevin Traynor Acked-by: Qi Zhang --- drivers/net/i40e/i40e_pf.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/net/i40e/i40e_pf.c b/drivers/net/i40e/i40e_pf.c index 585b21cbcc..0c4bdbcd18 100644 --- a/drivers/net/i40e/i40e_pf.c +++ b/drivers/net/i40e/i40e_pf.c @@ -1250,11 +1250,9 @@ i40e_pf_host_process_cmd_request_queues(struct i40e_pf_vf *vf, uint8_t *msg) pf = vf->pf; - if (req_pairs <= 0) { - PMD_DRV_LOG(ERR, - "VF %d tried to request %d queues. Ignoring.\n", - vf->vf_idx, - I40E_MAX_QP_NUM_PER_VF); + if (req_pairs == 0) { + PMD_DRV_LOG(ERR, "VF %d tried to request 0 queues. Ignoring.\n", + vf->vf_idx); } else if (req_pairs > I40E_MAX_QP_NUM_PER_VF) { PMD_DRV_LOG(ERR, "VF %d tried to request more than %d queues.\n", @@ -1263,7 +1261,7 @@ i40e_pf_host_process_cmd_request_queues(struct i40e_pf_vf *vf, uint8_t *msg) vfres->num_queue_pairs = I40E_MAX_QP_NUM_PER_VF; } else if (req_pairs > cur_pairs + pf->qp_pool.num_free) { PMD_DRV_LOG(ERR, - "VF %d requested %d more queues, but noly %d left\n", + "VF %d requested %d more queues, but only %d left\n", vf->vf_idx, req_pairs - cur_pairs, pf->qp_pool.num_free); -- 2.20.1