From 82bae1ea01850455e8ef9fafffca70879e5393ca Mon Sep 17 00:00:00 2001 From: Matan Azrad Date: Mon, 12 Feb 2018 20:51:41 +0000 Subject: [PATCH] net/failsafe: fix removal scope The fail-safe PMD uses a per sub-device flag called "remove" to indicate the scope where the sub-device was removed physically and whether its software resources should be released. This flag is set when the fail-safe receives an RMV notification about the physical removal of the sub-device, and should be unset when all the sub-device resources are released. The previous code wrongly unsets the flag in dev_configure(), instead of when the software resources release is completed. Change the remove flag unsetting to take action in the end of the software resources release. Fixes: a46f8d5 ("net/failsafe: add fail-safe PMD") Cc: stable@dpdk.org Signed-off-by: Matan Azrad Acked-by: Gaetan Rivet --- drivers/net/failsafe/failsafe_ether.c | 1 + drivers/net/failsafe/failsafe_ops.c | 1 - 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/failsafe/failsafe_ether.c b/drivers/net/failsafe/failsafe_ether.c index 4c6e938d65..d820fafd87 100644 --- a/drivers/net/failsafe/failsafe_ether.c +++ b/drivers/net/failsafe/failsafe_ether.c @@ -280,6 +280,7 @@ fs_dev_remove(struct sub_device *sdev) /* the end */ break; } + sdev->remove = 0; failsafe_hotplug_alarm_install(sdev->fs_dev); } diff --git a/drivers/net/failsafe/failsafe_ops.c b/drivers/net/failsafe/failsafe_ops.c index 7a67e16895..f0e48c1880 100644 --- a/drivers/net/failsafe/failsafe_ops.c +++ b/drivers/net/failsafe/failsafe_ops.c @@ -131,7 +131,6 @@ fs_dev_configure(struct rte_eth_dev *dev) dev->data->dev_conf.intr_conf.lsc = 0; } DEBUG("Configuring sub-device %d", i); - sdev->remove = 0; ret = rte_eth_dev_configure(PORT_ID(sdev), dev->data->nb_rx_queues, dev->data->nb_tx_queues, -- 2.20.1