From 84191ddeb53dcabb2567422ebf4612dea14d2471 Mon Sep 17 00:00:00 2001 From: Anatoly Burakov Date: Thu, 14 Nov 2019 13:58:21 +0000 Subject: [PATCH] mempool: remove check for bad IOVA when populating Currently, mempool will check if IOVA is bad for a segment, and reject the IOVA if hugepages are also enabled. This check is wrong because now that we have external memory segments, they are allowed to have their IOVA's to be invalid. This check also doesn't make much sense in the first place, because the following code can handle bad IOVA's perfectly well (and in fact, this check is not triggering a failure when --no-huge option is enabled), so there is not much sense to check for this in the first place. Fixes: 950e8fb4e194 ("mem: allow registering external memory areas") Cc: stable@dpdk.org Signed-off-by: Anatoly Burakov Acked-by: Olivier Matz Tested-by: Bo Chen --- lib/librte_mempool/rte_mempool.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/lib/librte_mempool/rte_mempool.c b/lib/librte_mempool/rte_mempool.c index 8da2e471c7..78d8eb941e 100644 --- a/lib/librte_mempool/rte_mempool.c +++ b/lib/librte_mempool/rte_mempool.c @@ -390,11 +390,6 @@ rte_mempool_populate_virt(struct rte_mempool *mp, char *addr, iova = get_iova(addr + off); - if (iova == RTE_BAD_IOVA && rte_eal_has_hugepages()) { - ret = -EINVAL; - goto fail; - } - /* populate with the largest group of contiguous pages */ for (phys_len = RTE_MIN( (size_t)(RTE_PTR_ALIGN_CEIL(addr + off + 1, pg_sz) - -- 2.20.1