From 85fc592a35d69bf6743158f6bef38b7fa40a5bc0 Mon Sep 17 00:00:00 2001 From: Volodymyr Fialko Date: Thu, 9 Jun 2022 11:27:31 +0200 Subject: [PATCH] crypto/cnxk: fix condition check The value of ec_mdata cannot be NULL, instead check that value of private_data_offset was set. Coverity issue: 378861, 378865 Fixes: 97ebfda82910 ("crypto/cnxk: add event metadata set operation") Signed-off-by: Volodymyr Fialko Acked-by: Anoob Joseph --- drivers/crypto/cnxk/cn10k_cryptodev_ops.c | 4 ++-- drivers/crypto/cnxk/cn9k_cryptodev_ops.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/crypto/cnxk/cn10k_cryptodev_ops.c b/drivers/crypto/cnxk/cn10k_cryptodev_ops.c index dd4c1d99d5..c2046d8d39 100644 --- a/drivers/crypto/cnxk/cn10k_cryptodev_ops.c +++ b/drivers/crypto/cnxk/cn10k_cryptodev_ops.c @@ -350,10 +350,10 @@ cn10k_ca_meta_info_extract(struct rte_crypto_op *op, uint8_t cdev_id; uint16_t qp_id; + if (unlikely(op->private_data_offset == 0)) + return -EINVAL; ec_mdata = (union rte_event_crypto_metadata *) ((uint8_t *)op + op->private_data_offset); - if (!ec_mdata) - return -EINVAL; rsp_info = &ec_mdata->response_info; cdev_id = ec_mdata->request_info.cdev_id; qp_id = ec_mdata->request_info.queue_pair_id; diff --git a/drivers/crypto/cnxk/cn9k_cryptodev_ops.c b/drivers/crypto/cnxk/cn9k_cryptodev_ops.c index ed25afeb64..9f697c79c3 100644 --- a/drivers/crypto/cnxk/cn9k_cryptodev_ops.c +++ b/drivers/crypto/cnxk/cn9k_cryptodev_ops.c @@ -402,10 +402,10 @@ cn9k_ca_meta_info_extract(struct rte_crypto_op *op, uint8_t cdev_id; uint16_t qp_id; + if (unlikely(op->private_data_offset == 0)) + return -EINVAL; ec_mdata = (union rte_event_crypto_metadata *) ((uint8_t *)op + op->private_data_offset); - if (!ec_mdata) - return -EINVAL; rsp_info = &ec_mdata->response_info; cdev_id = ec_mdata->request_info.cdev_id; qp_id = ec_mdata->request_info.queue_pair_id; -- 2.39.5