From 8a2d3bd64c69817e772717d98836eb15fe8b0ff8 Mon Sep 17 00:00:00 2001 From: Hongbo Zheng Date: Thu, 29 Oct 2020 20:51:53 +0800 Subject: [PATCH] net/hns3: fix unchecked return value There are coverity defects related "calling hns3_reset_all_tqps without checking return value in hns3_do_start". This patch fixes the warning by add "void" declaration because here is exception handling, hns3_reset_all_tqps will have the corresponding error message if it is handled incorrectly, so it is not necessary to check hns3_reset_all_tqps return value, here keep ret as the error code causing the exception. Coverity issue: 363048 Fixes: fa29fe45a7b4 ("net/hns3: support queue start and stop") Cc: stable@dpdk.org Signed-off-by: Hongbo Zheng Signed-off-by: Lijun Ou --- drivers/net/hns3/hns3_ethdev.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/net/hns3/hns3_ethdev.c b/drivers/net/hns3/hns3_ethdev.c index 6342c70ca2..6b4be769bf 100644 --- a/drivers/net/hns3/hns3_ethdev.c +++ b/drivers/net/hns3/hns3_ethdev.c @@ -4752,7 +4752,13 @@ hns3_do_start(struct hns3_adapter *hns, bool reset_queue) err_config_mac_mode: hns3_dev_release_mbufs(hns); - hns3_reset_all_tqps(hns); + /* + * Here is exception handling, hns3_reset_all_tqps will have the + * corresponding error message if it is handled incorrectly, so it is + * not necessary to check hns3_reset_all_tqps return value, here keep + * ret as the error code causing the exception. + */ + (void)hns3_reset_all_tqps(hns); return ret; } -- 2.20.1